Refactor actuators around a scoped struct #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/L
vincepri
force-pushed
the
actuator-refactor-phase1
branch
2 times, most recently
from
96a4fec to
871dfb6
Compare
k8s-ci-robot
added
size/XL
vincepri
force-pushed
the
actuator-refactor-phase1
branch
2 times, most recently
from
c770b99 to
0e2f852
Compare
vincepri
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
vincepri
changed the title
vincepri
force-pushed
the
actuator-refactor-phase1
branch
from
fc0bb81 to
83c24fd
Compare
Signed-off-by: Vince Prignano <[email protected]>
vincepri
force-pushed
the
actuator-refactor-phase1
branch
from
83c24fd to
e5a8962
Compare
|
/retest |
|
@chuckha ptal |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano [email protected]
What this PR does / why we need it:
This PR is the first phase for the larger refactoring discussed in #305. Introduces the concept of actuator
Scope(andMachineScope) and modifies the actuators to make use of it. It's very early stages and it's aimed mostly at moving coding to another place. The end goal is to have scoped services which evolve around these contexts and separate the service responsibilities.